Skip to content

Wrong order of resolutions list #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
inspirit opened this issue Sep 12, 2023 · 1 comment
Closed

Wrong order of resolutions list #44

inspirit opened this issue Sep 12, 2023 · 1 comment

Comments

@inspirit
Copy link

The order of resolutions are from high to low in generator:
https://github.com/lucidrains/gigagan-pytorch/blob/9a364dd33cf0ff053ea01041e02bc41949e53609/gigagan_pytorch/gigagan_pytorch.py#L919C9-L919C20

should be reversed I suppose?
lucidrains added a commit that referenced this issue Sep 12, 2023
@lucidrains
address issue with resolutions in generator for calculating attention…
3ce4c52 
… placement, thanks to @inspirit #44
@lucidrains
Copy link
Owner

@inspirit hey, thanks for the code review! should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucidrains @inspirit