Skip to content

Refactor Network constraint #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2020
Merged

Refactor Network constraint #329

merged 2 commits into from
May 29, 2020

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented May 29, 2020

Breaking Changes

  • .internet(atLeast: .any) is forbidden. It's already default behaviour
  • Cannot use internet constraint if Operation are running in main thread

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #329 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   87.80%   87.81%   +0.01%     
==========================================
  Files          36       36              
  Lines        1812     1806       -6     
==========================================
- Hits         1591     1586       -5     
+ Misses        221      220       -1     
Impacted Files Coverage Δ
Tests/SwiftQueueTests/LoggerTests.swift 100.00% <ø> (ø)
Tests/SwiftQueueTests/SwiftQueueBuilderTests.swift 100.00% <ø> (ø)
Tests/SwiftQueueTests/SwiftQueueManagerTests.swift 100.00% <ø> (ø)
Sources/SwiftQueue/Constraint+Network.swift 66.66% <100.00%> (+3.33%) ⬆️
Sources/SwiftQueue/JobBuilder.swift 90.66% <100.00%> (+0.12%) ⬆️
Sources/SwiftQueue/JobInfo.swift 100.00% <100.00%> (ø)

@lucas34 lucas34 merged commit a1324db into master May 29, 2020
@lucas34 lucas34 deleted the network-refactor branch May 29, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant