Skip to content

Background Task integration Extension #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Background Task integration Extension #251

merged 1 commit into from
Aug 22, 2019

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented Aug 19, 2019

@lucas-bot
Copy link
Collaborator

lucas-bot commented Aug 19, 2019

2 Warnings
⚠️ PR is classed as Work in Progress
⚠️ The podspec was updated, but there were no changes in either the Cartfile nor Package.swift. Did you forget updating Cartfile or Package.swift?

SwiftLint found issues

Warnings

File Line Reason
JobInfoSerializer+Decodable.swift 86 Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines (function_body_length)
SqOperation.swift 43 Setter value is not used. (unused_setter_value)
SqOperation.swift 44 Setter value is not used. (unused_setter_value)
SqOperation.swift 45 Setter value is not used. (unused_setter_value)
SqOperation.swift 41 Initializing an optional variable with nil is redundant. (redundant_optional_initialization)
SwiftQueueManagerTests.swift 228 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
SwiftQueueManagerTests.swift 218 Line should be 140 characters or less: currently 142 characters (line_length)
SwiftQueueManagerTests.swift 219 Line should be 140 characters or less: currently 144 characters (line_length)

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #251 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #251      +/-   ##
=========================================
+ Coverage   95.68%   95.8%   +0.12%     
=========================================
  Files          27      27              
  Lines        2084    2146      +62     
=========================================
+ Hits         1994    2056      +62     
  Misses         90      90
Impacted Files Coverage Δ
Sources/SwiftQueue/JobInfo.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/SwiftQueueManager.swift 89.47% <100%> (+1.23%) ⬆️
Sources/SwiftQueue/SqOperation.swift 96.12% <100%> (+0.05%) ⬆️
Sources/SwiftQueue/JobInfoSerializer+V1.swift 83.5% <100%> (+0.34%) ⬆️
Sources/SwiftQueue/JobBuilder.swift 94.11% <100%> (+0.08%) ⬆️
...urces/SwiftQueue/JobInfoSerializer+Decodable.swift 82.3% <100%> (+0.48%) ⬆️
Tests/SwiftQueueTests/SwiftQueueManagerTests.swift 100% <100%> (ø) ⬆️

@lucas34 lucas34 self-assigned this Aug 19, 2019
@lucas34 lucas34 force-pushed the bg-task branch 16 times, most recently from 489ba11 to 7be4d0d Compare August 22, 2019 00:50
@lucas34 lucas34 changed the title [WIP] Background Task integration Background Task integration Extenssion Aug 22, 2019
@lucas34 lucas34 changed the title Background Task integration Extenssion Background Task integration Extension Aug 22, 2019
@lucas34 lucas34 merged commit b75b779 into master Aug 22, 2019
@lucas34 lucas34 deleted the bg-task branch August 22, 2019 03:29
@lucas-bot lucas-bot mentioned this pull request Sep 21, 2019
@lucas-bot lucas-bot mentioned this pull request Oct 10, 2019
@lucas-bot lucas-bot mentioned this pull request Nov 3, 2019
@github-actions github-actions bot mentioned this pull request Jun 29, 2022
@github-actions github-actions bot mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants