Skip to content

Better control on running for duplicate job constraint #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2019

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented May 12, 2019

Resolve #210

@lucas-bot
Copy link
Collaborator

lucas-bot commented May 12, 2019

SwiftLint found issues

Warnings

File Line Reason
SwiftQueueManagerTests.swift 166 Line should be 140 characters or less: currently 161 characters (line_length)

Spell Checker found issues

CHANGELOG.md

Line Typo
11 - Rename synchronous to initInBackground (#213)
110 - Change signature of Limit(Int) to Limit(Double)
140 - SwiftQueue.swift reference all public protocol
169 - JobBuilder.retry(Limit)
170 - JobBuilder.periodic(Limit, TimeInterval)
208 - Job is now immediately canceled when the deadline is reached

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #219 into master will increase coverage by 0.29%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   96.48%   96.77%   +0.29%     
==========================================
  Files          26       26              
  Lines        1934     1987      +53     
==========================================
+ Hits         1866     1923      +57     
+ Misses         68       64       -4
Impacted Files Coverage Δ
Sources/SwiftQueue/SwiftQueue.swift 100% <ø> (ø) ⬆️
Tests/SwiftQueueTests/SwiftQueueManagerTests.swift 100% <ø> (ø) ⬆️
Sources/SwiftQueue/JobInfo.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/Constraint+UniqueUUID.swift 100% <100%> (ø) ⬆️
...ts/SwiftQueueTests/ConstraintUniqueUUIDTests.swift 100% <100%> (ø) ⬆️
Sources/SwiftQueue/JobInfoSerializer+V1.swift 82.41% <100%> (+0.39%) ⬆️
Sources/SwiftQueue/JobBuilder.swift 93.44% <100%> (+0.1%) ⬆️
...urces/SwiftQueue/JobInfoSerializer+Decodable.swift 80% <100%> (+0.61%) ⬆️
Sources/SwiftQueue/Constraint+Deadline.swift 100% <0%> (+22.22%) ⬆️

@lucas34 lucas34 merged commit 64d54d8 into master May 12, 2019
@lucas34 lucas34 deleted the duplicate-running-job branch May 12, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Allowing at most 2 jobs of the same type
2 participants