Skip to content

tickets/SP-2004: move opsim simulation archive submodule out of rubin_scheduler into rubin_sim #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

ehneilsen
Copy link
Collaborator

No description provided.

@ehneilsen ehneilsen requested a review from rhiannonlynne March 20, 2025 17:55
Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks good, but I think we have a tiny API detail to sort out between the fetch_prenight_visits and the fetch_obsloctap_visits that requires a clarification from Wil.

#SBATCH --nodes=1 # Number of nodes
#SBATCH --ntasks=1 # Number of tasks run in parallel
#SBATCH --cpus-per-task=1 # Number of CPUs per task
#SBATCH --mem=16G # Requested memory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about the configuration for this job.
I think it's asking for 1 cpu, and the memory footprint for a single cpu on the milano nodes is generally pretty small (I think it's about 4GB).
I wouldn't have expected this particular job to need 16GB, so if it doesn't, it seems like it would be easier for scheduling to have the requested memory be a bit smaller.

#SBATCH --nodes=1 # Number of nodes
#SBATCH --ntasks=1 # Number of tasks run in parallel
#SBATCH --cpus-per-task=1 # Number of CPUs per task
#SBATCH --mem=16G # Requested memory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment about the memory usage as for the compile metadata script.

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (following convo on slack about new obsloctap updates).

@ehneilsen ehneilsen force-pushed the tickets/SP-2004 branch 2 times, most recently from 8da38d7 to 0f4c252 Compare March 27, 2025 15:36
@ehneilsen ehneilsen merged commit 2919ed9 into main Mar 27, 2025
9 checks passed
@ehneilsen ehneilsen deleted the tickets/SP-2004 branch April 2, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants