-
Notifications
You must be signed in to change notification settings - Fork 39
tickets/SP-2004: move opsim simulation archive submodule out of rubin_scheduler into rubin_sim #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this looks good, but I think we have a tiny API detail to sort out between the fetch_prenight_visits
and the fetch_obsloctap_visits
that requires a clarification from Wil.
#SBATCH --nodes=1 # Number of nodes | ||
#SBATCH --ntasks=1 # Number of tasks run in parallel | ||
#SBATCH --cpus-per-task=1 # Number of CPUs per task | ||
#SBATCH --mem=16G # Requested memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering about the configuration for this job.
I think it's asking for 1 cpu, and the memory footprint for a single cpu on the milano nodes is generally pretty small (I think it's about 4GB).
I wouldn't have expected this particular job to need 16GB, so if it doesn't, it seems like it would be easier for scheduling to have the requested memory be a bit smaller.
batch/run_prenight_sims.sh
Outdated
#SBATCH --nodes=1 # Number of nodes | ||
#SBATCH --ntasks=1 # Number of tasks run in parallel | ||
#SBATCH --cpus-per-task=1 # Number of CPUs per task | ||
#SBATCH --mem=16G # Requested memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment about the memory usage as for the compile metadata script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved (following convo on slack about new obsloctap updates).
8da38d7
to
0f4c252
Compare
0f4c252
to
d1d49f7
Compare
No description provided.