-
Notifications
You must be signed in to change notification settings - Fork 39
OPSIM-1155: Update DDF metrics / metric_subsets #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead of trying to make a filled bar plot (which wasn't actually used), now "filled_data" fills the metric_values with their fill value (instead of only allowing masking).
…o UniSlicer metrics to not fail when metric returns a histogram (ie. for the SummaryHistogram plotter).
NvisitsPerNight now works on Unislicer (receiving all visits per DDF, not just those at the center). Added CoaddPerNight metric. Fixed SeasonLength plot labels.
I guess this is likely to fail unit tests until we make a new tag for rubin_scheduler (to add the "get_current_footprint" function) |
Ok - I needed to update the data download for MAF to add the metric_subsets.json file and a small h5 summary stat test file. |
Black fix test failures Black again Ruff updates in import names
d691dc6
to
85075ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all reasonable.
Seems like there's a tests_2024_04_23.tgz
file that got created but isn't being used. We should update to using that one or delete it off sdf to avoid confusion.
Thanks - I thought the tests had been updated at some point, but I was just going with what was in the previous dictionary. Will update the tests to use the new version (which just drops the skybrightnessPre files from the tests directory) and double-check. |
In preparation for making a summary for the DDF working group, this PR