Skip to content

tickets/PREOPS-4501: Do not delete old SkyModelPre attributes until we know if new ones are valid #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2023
Merged

tickets/PREOPS-4501: Do not delete old SkyModelPre attributes until we know if new ones are valid #377

merged 1 commit into from
Nov 3, 2023

Conversation

ehneilsen
Copy link
Collaborator

This probably doesn't come up in simulations, but can be a problem in interactive dashboards.

@ehneilsen ehneilsen requested a review from yoachim October 31, 2023 15:35
yoachim
yoachim approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@yoachim yoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Could also do for attr in [self.sb, self.filternames, self.timestep_max]: to save a few lines.

@ehneilsen ehneilsen force-pushed the tickets/PREOPS-4501 branch from dc73eea to 169a603 Compare November 2, 2023 20:37
@ehneilsen ehneilsen force-pushed the tickets/PREOPS-4501 branch from 169a603 to 2952d0b Compare November 3, 2023 18:13
@ehneilsen ehneilsen merged commit 7d1eb19 into main Nov 3, 2023
@ehneilsen ehneilsen deleted the tickets/PREOPS-4501 branch November 3, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoachim yoachim yoachim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehneilsen @yoachim