DM-50031: Add support for per-detector filter transmission files for LSSTCam #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a config to skip over non-science detectors.
cmsaunders
approved these changes
May 8, 2025
| doc="Filter transmission curve per detector", | ||
| name="transmission_filter_detector", | ||
| storageClass="TransmissionCurve", | ||
| dimensions=("instrument", "physical_filter", "detector",), |
There was a problem hiding this comment.
Should this also have "band" in the dimensions, like transmission_filter?
| @@ -291,6 +311,11 @@ class FgcmMakeLutConfig(pipeBase.PipelineTaskConfig, | |||
| dtype=bool, | |||
| default=True, | |||
| ) | |||
| doFilterDetectorTransmission = pexConfig.Field( | |||
| doc="Use per-detector filter transmissions?", | |||
There was a problem hiding this comment.
Without context, it's not clear that "per-detector" is the important distinction here. Maybe add "If false, the same filter transmission is used for all detectors".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.