Skip to content

feat: workflow job status updates #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 1, 2025
Merged

Conversation

gbanu
Copy link
Contributor

@gbanu gbanu commented Jun 1, 2025

  • Saving no data regarding Job status in the backend.
  • frontend -> backend -> github API
  • from the video you can see that the status is updated with a lag, but eventually catches up
  • job status is only shown during deployment to simplify the view

Update:

  • since api laggy anyways increase interval to 5 sec
  • since api so laggy keep fetching for 1 min after deployment failed to display the results
  • add waiting for approval
Screenshot 2025-06-01 at 18 26 21
  • add fat button to GH if something failed
Screenshot 2025-06-01 at 19 46 41

Copy link

codacy-production bot commented Jun 1, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.14% (target: -1.00%) 9.15%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6472efd) 7721 1984 25.70%
Head commit (e5cada2) 7869 (+148) 2011 (+27) 25.56% (-0.14%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#774) 142 13 9.15%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link
Member

@egekocabas egekocabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏🏻

@egekocabas egekocabas merged commit 01da266 into staging Jun 1, 2025
15 checks passed
@egekocabas egekocabas deleted the deployment-status-updates branch June 1, 2025 19:03
@gbanu gbanu linked an issue Jun 1, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment status information
2 participants