Skip to content

feat: Adding comments to releases #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 30, 2025
Merged

Conversation

TurkerKoc
Copy link
Member

@TurkerKoc TurkerKoc commented May 28, 2025

Copy link

codacy-production bot commented May 28, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 6.25%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bdfba9d) 7694 1737 22.58%
Head commit (f5f32c3) 7721 (+27) 1739 (+2) 22.52% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#763) 32 2 6.25%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@TurkerKoc TurkerKoc marked this pull request as ready for review May 28, 2025 23:15
@TurkerKoc TurkerKoc requested a review from a team as a code owner May 28, 2025 23:15
@TurkerKoc TurkerKoc linked an issue May 29, 2025 that may be closed by this pull request
@TurkerKoc TurkerKoc requested a review from egekocabas May 30, 2025 00:05
Copy link
Member

@egekocabas egekocabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this valuable feature 🙏🏻

I have updated it so

  • We can click the same evaluation button if we already did one. Since we introduced comments, user may forgot to add comment or later on want to add a comment.
  • Also passed the existing evaluation's comment (if exist) to the popup (if it is the same evaluation). Thinking that user may want to update their existing comment.

@egekocabas egekocabas merged commit f2ff655 into staging May 30, 2025
16 checks passed
@egekocabas egekocabas deleted the feat/comment-on-releases branch May 30, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release marked as broken comments
2 participants