Skip to content

feat: improve confirmation dialogs #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 29, 2025
Merged

feat: improve confirmation dialogs #741

merged 16 commits into from
May 29, 2025

Conversation

egekocabas
Copy link
Member

@egekocabas egekocabas commented May 21, 2025

Screenshots

Lock

image
image

Publish draft release

image
image

Secret generation

image
image

Deployment

Test server

Without required reviewers

image
image

With required reviewers

image
image

Staging server

Without required reviewers

image
image

With required reviewers

image
image

Production server

Without required reviewers

image
image

With required reviewers

image
image

Copy link

codacy-production bot commented May 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 11.90%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bacfa5a) 7617 988 12.97%
Head commit (e2bb39b) 7687 (+70) 998 (+10) 12.98% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#741) 84 10 11.90%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@egekocabas egekocabas linked an issue May 21, 2025 that may be closed by this pull request
@github-actions github-actions bot added size:XL and removed size:L labels May 21, 2025
@egekocabas egekocabas changed the title feat: improve deploy dialog feat: improve confirmation dialogs May 22, 2025
# Conflicts:
#	client/src/app/components/environments/environment-list/environment-list-view.component.ts
@egekocabas egekocabas marked this pull request as ready for review May 22, 2025 22:21
@egekocabas egekocabas requested a review from a team as a code owner May 22, 2025 22:21
@thielpa
Copy link
Contributor

thielpa commented May 25, 2025

Could you please add truncation to the modal headers when using environment names or something dynamic? :)

@egekocabas
Copy link
Member Author

Could you please add truncation to the modal headers when using environment names or something dynamic? :)

I tried to truncate but it looks really bad and only very small environment names can fit into. I also don't want to increase the width of dialog, and also in order to be consistent with other popups; i just removed the environment name from the header. It is also written inside the dialog 😅 What do you think?

@TurkerKoc
Copy link
Member

Could you please add truncation to the modal headers when using environment names or something dynamic? :)

I tried to truncate but it looks really bad and only very small environment names can fit into. I also don't want to increase the width of dialog, and also in order to be consistent with other popups; i just removed the environment name from the header. It is also written inside the dialog 😅 What do you think?

I think this is perfectly fine

Copy link
Member

@TurkerKoc TurkerKoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reiterating on all the dialogs! All of them looks perfect 🚀

@egekocabas egekocabas merged commit 5078ff6 into staging May 29, 2025
16 checks passed
@egekocabas egekocabas deleted the feat/improve-dialogs branch May 29, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment Dialog Improvements
3 participants