-
Notifications
You must be signed in to change notification settings - Fork 1
feat: improve confirmation dialogs #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
# Conflicts: # client/src/app/components/environments/environment-list/environment-list-view.component.ts
Could you please add truncation to the modal headers when using environment names or something dynamic? :) |
I tried to truncate but it looks really bad and only very small environment names can fit into. I also don't want to increase the width of dialog, and also in order to be consistent with other popups; i just removed the environment name from the header. It is also written inside the dialog 😅 What do you think? |
I think this is perfectly fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reiterating on all the dialogs! All of them looks perfect 🚀
Screenshots
Lock
Publish draft release
Secret generation
Deployment
Test server
Without required reviewers
With required reviewers
Staging server
Without required reviewers
With required reviewers
Production server
Without required reviewers
With required reviewers