-
Notifications
You must be signed in to change notification settings - Fork 315
Development
: Initialize new Hyperion module for programming exercise creation assistance and migrate functionality from Iris
#11047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from 19 commits
46b6282
b474286
14aaa91
8f50919
2bd5aaf
5487471
4a2b2ac
17abce5
0e70993
110571a
16ee5b5
b11dfcd
07327be
d809307
edcd30e
fc5cd5e
a3634d7
01bd1d6
48b97a0
a1072be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,6 @@ | ||||||
package de.tum.cit.aet.artemis; | ||||||
|
||||||
import static de.tum.cit.aet.artemis.core.config.Constants.PROFILE_HYPERION; | ||||||
import static de.tum.cit.aet.artemis.core.config.Constants.UPLOADS_FILE_PATH_DEFAULT; | ||||||
import static de.tum.cit.aet.artemis.core.config.Constants.UPLOADS_FILE_PATH_PROPERTY_NAME; | ||||||
import static tech.jhipster.config.JHipsterConstants.SPRING_PROFILE_DEVELOPMENT; | ||||||
|
@@ -78,6 +79,8 @@ public void initApplication() { | |||||
public static void main(String[] args) { | ||||||
SpringApplication app = new SpringApplication(ArtemisApp.class); | ||||||
DefaultProfileUtil.addDefaultProfile(app); | ||||||
// Enable Hyperion profile by default TODO: REMOVE!!!!!!!!!!!!!!!!!!!!!!!!!! | ||||||
app.setAdditionalProfiles(PROFILE_HYPERION); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO REMOVE
Comment on lines
+82
to
+83
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove temporary development code before production deployment. This temporary code enables the Hyperion profile by default in the main application class, which could have unintended consequences in production environments. The excessive exclamation marks in the TODO comment also indicate this is not production-ready code. Consider these alternatives:
Apply this diff to remove the temporary code: - // Enable Hyperion profile by default TODO: REMOVE!!!!!!!!!!!!!!!!!!!!!!!!!!
- app.setAdditionalProfiles(PROFILE_HYPERION); Then configure the profile activation through proper Spring Boot configuration mechanisms (application.properties, environment variables, or command-line arguments). 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||
var context = app.run(args); | ||||||
Environment env = context.getEnvironment(); | ||||||
String fileUploadPath = env.getProperty(UPLOADS_FILE_PATH_PROPERTY_NAME); | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to the Hyperion documentation here.