Skip to content

Feat/webapp local persistence models #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 18, 2025
Merged

Feat/webapp local persistence models #178

merged 6 commits into from
May 18, 2025

Conversation

egenerse
Copy link
Collaborator

Checklist

  • I linked PR with a related issue
  • I added multiple screenshots/screencasts of my UI changes

Motivation and Context

This PR completes #141

Description

Steps for Testing

  1. Open website
  2. Add elements
  3. Create a new diagram with name
  4. Edit it
  5. Refresh the page and observer latest diagram is persistent
  6. Click load diagram
  7. Load different diagram from the list
  8. See diagram is loaded and you can edit it
  9. Check application local storage if diagrams are there
  10. Check redux devtoolkit to see actions
  11. Open Load diagram modal and delete some
  12. Check application local storage and see diagrams list has changed

Screenshots

aaa.mov

@egenerse egenerse self-assigned this May 18, 2025
kurunbelemir
kurunbelemir approved these changes May 18, 2025
View reviewed changes
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update nodes in order to apply diagram name changes, we discussed and we will fix in the feature branch.

@egenerse egenerse added the build and push docker image Build and pushe docker image with tag label May 18, 2025
@egenerse egenerse added build and push docker image Build and pushe docker image with tag and removed build and push docker image Build and pushe docker image with tag labels May 18, 2025
@egenerse egenerse merged commit 147bd45 into main May 18, 2025
9 checks passed
@egenerse egenerse deleted the feat/webapp-local-persistence-models branch May 18, 2025 16:02
@egenerse egenerse mentioned this pull request May 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurunbelemir kurunbelemir kurunbelemir approved these changes

Assignees

@egenerse egenerse

Labels
build and push docker image Build and pushe docker image with tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egenerse @kurunbelemir