Skip to content

Fix bug error panic OCPP 1.6J security features (CentralSystem) #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

dwibudut
Copy link
Contributor

@dwibudut dwibudut commented Oct 9, 2024

Proposed changes

(1) Fix panic when get response proto-error on OCPP 1.6J Security features CentralSystem
(2) Fix connectorId field validation on ExtendedTriggerMessageRequest feature base on OCPP 1.6J security extension specification

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

(1) Example message to produce panic when get response proto-error on OCPP 1.6J Security features CentralSystem

Request message:

[2,"1457709147","ExtendedTriggerMessage",{"requestedMessage":"SignChargePointCertificate"}]

Response message:

[4,"1457709147","NotSupported","Feature not implemented",{}]

CentralSystem will get panic:

...
panic: interface conversion: ocpp.Response is nil, not *extendedtriggermessage.ExtendedTriggerMessageResponse
...


(2) Field connectorId of ExtendedTriggerMessageRequest on OCPP 1.6J Security specification

image


@lorenzodonini lorenzodonini merged commit b4dec4e into lorenzodonini:master Oct 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants