Add Connections method in websocket #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Just fyi, I'll be refactoring the websocket package a bit, meaning you might see different struct naming next time you look at this (I'll try not to break existing implementations). I'll definitely keep your addition though 👍 |
xBlaz3kx
reviewed
Jan 19, 2025
| @@ -371,6 +375,10 @@ func (server *Server) Addr() *net.TCPAddr { | |||
| return server.addr | |||
| } | |||
|
|
|||
| func (server *Server) Connections(websocketId string) *WebSocket { | |||
| return server.connections[websocketId] | |||
There was a problem hiding this comment.
Shouldn't this be thread-safe? Could happen you have a connection what is being removed at the same time and you get a stale connection map
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a method to get websocket connection information
Why
Some of the chargers we are dealing with do not support websocket ping/pong frames and the Disconnected hook may not be called when the connection is lost. So we need the connection information to reconcile the status of the connected chargers.