Fix validation for connectorId of GetCompositeSchedule.conf #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x a few implicitly copied locks
initialed85
commented
May 29, 2024
initialed85
commented
May 29, 2024
initialed85
commented
May 29, 2024
lorenzodonini
approved these changes
Jul 2, 2024
|
Hey, sorry for the late review and thanks a lot for the contribution! Approved & merged |
Thx @lorenzodonini! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This lib is awesome, we've built a production OCPP server around it and it's going great!
This PR fixes the validation of the
connectorIdfield ofGetCompositeSchedule.conf(#276); I believe this fix is in keeping w/ OCPP 1.6:An excerpt re:
GetCompositeSchedule:While I was in the code I also ran
go fmtand tidied up a couple of (probably unimportant)go vetfailures around copied locks in test code.