feat: add information for extra fields as extensions to openapi specs #10460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15955595664Details
💛 - Coveralls |
aaqilniz
force-pushed
the
fix/property-info-in-specs
branch
4 times, most recently
from
7b5d640 to
b3ad346
Compare
aaqilniz
force-pushed
the
fix/property-info-in-specs
branch
2 times, most recently
from
9d58cbb to
8b6bebb
Compare
8 tasks
achrinza
requested changes
Nov 10, 2024
aaqilniz
force-pushed
the
fix/property-info-in-specs
branch
from
8b6bebb to
2a0fd04
Compare
aaqilniz
changed the title
achrinza
approved these changes
Nov 10, 2024
|
@aaqilniz, I think this PR is good to merge once the merge conflict has resolved. I believe you can merge the PR too. :) |
|
@aaqilniz, looks like there are some merge conflicts. Could you please resolve that? Thanks. |
aaqilniz
force-pushed
the
fix/property-info-in-specs
branch
from
2a0fd04 to
569ebb9
Compare
Signed-off-by: Muhammad Aaqil <[email protected]>
aaqilniz
force-pushed
the
fix/property-info-in-specs
branch
from
569ebb9 to
bb52423
Compare
|
Hi, @dhmlau. I have updated the PR. I think we can merge it now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openapi specs generated do not show information about other attributes of the model property like length, scale or generated, etc. This PR adds those attributes as extensions to openapi specs.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈