-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add important note of the introduction of upgrade path crd validation #1081
base: master
Are you sure you want to change the base?
doc: add important note of the introduction of upgrade path crd validation #1081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, LGTM.
CI failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be applied to every version associated.
…ation ref: longhorn/longhorn 10644 Signed-off-by: Jack Lin <[email protected]>
a44b36c
to
fcc827e
Compare
✅ Deploy Preview for longhornio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for your consideration.
The change was made for one version only but needs replicating to the other versions.
Thank you
|
||
### CRD Upgrade Validation | ||
|
||
During the upgrade process, the Custom Resource Definition (CRD) may be applied after the new Longhorn manager starts. This ensures that the controller does not process objects containing deprecated data or fields. As a result, the Longhorn manager may fail at the beginning of the upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the upgrade process, the Custom Resource Definition (CRD) may be applied after the new Longhorn manager starts. This ensures that the controller does not process objects containing deprecated data or fields. As a result, the Longhorn manager may fail at the beginning of the upgrade. | |
During the upgrade process, the Custom Resource Definition (CRD) may be applied after the new Longhorn manager has started. This ensures that the controller does not process objects with deprecated data or fields. As a result, the Longhorn manager might fail at the start of the upgrade. |
|
||
During the upgrade process, the Custom Resource Definition (CRD) may be applied after the new Longhorn manager starts. This ensures that the controller does not process objects containing deprecated data or fields. As a result, the Longhorn manager may fail at the beginning of the upgrade. | ||
|
||
If the Longhorn manager crashes during the upgrade, check the logs to determine whether the failure is due to the CRD not being applied yet. The logs may contain error messages similar to the following example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the Longhorn manager crashes during the upgrade, check the logs to determine whether the failure is due to the CRD not being applied yet. The logs may contain error messages similar to the following example: | |
If the Longhorn manager crashes during the upgrade, check the logs to confirm whether the failure is due to the CRD not being applied yet. The logs may contain error messages similar to the following example: |
ref: longhorn/longhorn#10644