Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add important note of the introduction of upgrade path crd validation #1081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin commented Mar 28, 2025

@ChanYiLin ChanYiLin requested review from innobead and derekbit March 28, 2025 09:06
@ChanYiLin ChanYiLin self-assigned this Mar 28, 2025
@ChanYiLin ChanYiLin requested a review from a team as a code owner March 28, 2025 09:06
derekbit
derekbit previously approved these changes Mar 28, 2025
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, LGTM.

@derekbit
Copy link
Member

CI failed.

Copy link
Contributor

@sushant-suse sushant-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be applied to every version associated.

…ation

ref: longhorn/longhorn 10644

Signed-off-by: Jack Lin <[email protected]>
@ChanYiLin ChanYiLin force-pushed the LH10644_add_strict_validation_to_update_operation_when_upgrade branch from a44b36c to fcc827e Compare March 28, 2025 15:35
Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit fcc827e
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/67e6c1aea729100008bbb394
😎 Deploy Preview https://deploy-preview-1081--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sushant-suse sushant-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for your consideration.
The change was made for one version only but needs replicating to the other versions.

Thank you


### CRD Upgrade Validation

During the upgrade process, the Custom Resource Definition (CRD) may be applied after the new Longhorn manager starts. This ensures that the controller does not process objects containing deprecated data or fields. As a result, the Longhorn manager may fail at the beginning of the upgrade.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
During the upgrade process, the Custom Resource Definition (CRD) may be applied after the new Longhorn manager starts. This ensures that the controller does not process objects containing deprecated data or fields. As a result, the Longhorn manager may fail at the beginning of the upgrade.
During the upgrade process, the Custom Resource Definition (CRD) may be applied after the new Longhorn manager has started. This ensures that the controller does not process objects with deprecated data or fields. As a result, the Longhorn manager might fail at the start of the upgrade.


During the upgrade process, the Custom Resource Definition (CRD) may be applied after the new Longhorn manager starts. This ensures that the controller does not process objects containing deprecated data or fields. As a result, the Longhorn manager may fail at the beginning of the upgrade.

If the Longhorn manager crashes during the upgrade, check the logs to determine whether the failure is due to the CRD not being applied yet. The logs may contain error messages similar to the following example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the Longhorn manager crashes during the upgrade, check the logs to determine whether the failure is due to the CRD not being applied yet. The logs may contain error messages similar to the following example:
If the Longhorn manager crashes during the upgrade, check the logs to confirm whether the failure is due to the CRD not being applied yet. The logs may contain error messages similar to the following example:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants