[BUG] Fix errors in questions.yaml

[james-munson]

What's the task? Please describe

I noticed a few small errors from the addition of storage class node selector in #4576

Describe the items of the task (DoD, definition of done) you'd like

Please use a task list for items on a separate line with a clickable checkbox https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists

• item 1

Additional context

Add any other context or screenshots about the document request here.

[longhorn-io-github-bot]

Pre Ready-For-Testing Checklist

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are (thanks to @PhanLe1010 and @ejweber):

1. Fork and clone https://github.com/rancher/charts
2. Make a working branch. Edit this question.yaml
3. make zip to zip your changes
4. Push it to the fork, branch 6392-questions-yaml
5. Use Rancher UI to create a new repository and point to that fork and branch.
6. Try install Longhorn 102.2.1+up1.4.2 to see if your changes make sense. (Note that with multiple repositories defined that include Longhorn, the list of Apps that can be installed will be contain multiple instances of Longhorn, only one of which points to the forked repo, but you can tell by the date on the install chart after you select it. It will probably be the last one.)
7. During installation, put some values in the NodeSelector list.
8. Check the installed StorageClass to see that those values got installed.

Screen shot is in the PR. Note that the Node Selector options appear on the Storage Class Settings page, and are set correctly when installed.

I will leave the Rancher fork branch in place until the PR is committed, tested, and closed.

• Is there a workaround for the issue? If so, where is it documented?

• Does the PR include the explanation for the fix or the feature?
  Yes

• Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
  No chart change, only questions.yaml which is a UI component.

• Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?

• Which areas/issues this PR might have potential impacts on?
  Area: UI
  Issues

• If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?

• If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?

• If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?

• If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)

• If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?

• If labeled: require/manual-test-plan Has the manual test plan been documented?

• If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?

[ejweber]

Small nit. I think this is not a [DOC] type issue since it actually fixes functionality that was broken.

[innobead]

@james-munson Let's make sure the issues we are handling need to add to the current milestone. Also, add backport labels if needed.

cc @longhorn/dev

[innobead]

@longhorn/qa for any issues with review-coverage label mean we need to see why the bug happens. Is it duo to some missing test case coverage? If yes, need to improve our test case.

[chriscchien]

Verified with test steps

Can see nodeSelector set correctly in storageclass longhorn

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    longhorn.io/last-applied-configmap: |
      kind: StorageClass
      apiVersion: storage.k8s.io/v1
      metadata:
        name: longhorn
        annotations:
          storageclass.kubernetes.io/is-default-class: "true"
      provisioner: driver.longhorn.io
      allowVolumeExpansion: true
      reclaimPolicy: "Delete"
      volumeBindingMode: Immediate
      parameters:
        numberOfReplicas: "3"
        staleReplicaTimeout: "30"
        fromBackup: ""
        fsType: "ext4"
        dataLocality: "disabled"
        nodeSelector: "ip-172-31-34-163"

Following test steps, it will test rancher/chart to install longhorn v1.4.2, but it can not guarantee question.yaml will work properly on v1.6.x too because rancher does not support to install longhorn v1.6.x yet.

I would like to keep this ticket open until v1.6.x rancher chart ready and will test again question.yaml by install longhorn v1.6.x from Rancher

[innobead]

@chriscchien We should verify this, as we will have 1.6.1 rancher chart.

[chriscchien]

Use Rancher v2.8.2 to install Longhorn v1.6.1 and set nodeSelector in storageclass during the installation, the nodeSelector parameter applied correctly after Longhorn install complete.

> k get storageclass longhorn -o yaml | grep nodeSelector
        nodeSelector: "ip-172-31-45-216"
  nodeSelector: ip-172-31-45-216