-
Notifications
You must be signed in to change notification settings - Fork 35
fix: volume encryption not working in Talos 1.9.x (backport #485) #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cherry-pick of 93b0353 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
longhorn/longhorn-10584 Signed-off-by: Chin-Ya Huang <[email protected]> (cherry picked from commit 93b0353)
533af70
to
a2407b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue(s) this PR fixes:
Issue longhorn/longhorn#10584
What this PR does / why we need it:
-d -
for cryptsetup instead of-d /dev/stdin
for compatibility with newer Talos versions.Special notes for your reviewer:
None
Additional documentation or context
longhorn/longhorn#10584 (comment)
This is an automatic backport of pull request #485 done by [Mergify](https://mergify.com).