-
Notifications
You must be signed in to change notification settings - Fork 158
feat: cleanup orphaned instances while evicting node #3718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleanup orphaned instances while evicting node #3718
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
70e1871
to
bb7f39a
Compare
bb7f39a
to
247b5b4
Compare
247b5b4
to
1e9f509
Compare
Signed-off-by: Raphanus Lo <[email protected]>
1e9f509
to
543ce5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the quick improvment.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#6764
What this PR does / why we need it:
Implement orphaned runtime instance cleanup for evicting node.
LEP: longhorn/longhorn#10675
Special notes for your reviewer:
Additional documentation or context