fix(networking): cleanup service/endpoint if needed #3078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
from
37a000c to
6e6e488
Compare
Vicente-Cheng
changed the title
c3y1huang
reviewed
Aug 22, 2024
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
2 times, most recently
from
b8e8bae to
2411a2e
Compare
|
codeFactor checking failure is not related to this PR. |
james-munson
previously approved these changes
Aug 22, 2024
c3y1huang
requested changes
Aug 23, 2024
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
3 times, most recently
from
ce14bfc to
7e4a0a9
Compare
derekbit
reviewed
Aug 23, 2024
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
2 times, most recently
from
552adef to
072656f
Compare
derekbit
reviewed
Aug 23, 2024
derekbit
reviewed
Aug 23, 2024
c3y1huang
requested changes
Aug 23, 2024
derekbit
reviewed
Aug 23, 2024
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
2 times, most recently
from
ed2d224 to
c3c1673
Compare
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
from
c3c1673 to
ac704dd
Compare
derekbit
force-pushed
the
cleanup-service-endpoint
branch
from
ac704dd to
d5f67ad
Compare
|
Need @c3y1huang's final check and approval. Thank you. |
c3y1huang
requested changes
Aug 23, 2024
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
from
d5f67ad to
52691ad
Compare
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
from
52691ad to
4832e8c
Compare
c3y1huang
requested changes
Aug 23, 2024
We meet a corner case that the service/endpoint would not be
cleanup. That will cause the service keep the ClusterIP `None`.
With this config, the endpoint of sharemanager would not correct.
So the CSI driver cannot perform the mountpoint well.
We would like to have a checking mechanism to know if the service/
endpoint did not cleanup. Then we will cleanup the service/endpoint
to ensure the correct endpoint.
Remove the cleanup function in the setting controller, we could do
the cleanup on the sm controller
Signed-off-by: Vicente Cheng <[email protected]>
Co-authored-by: Chin-Ya Huang <[email protected]>
Co-authored-by: Derek Su <[email protected]>
Vicente-Cheng
force-pushed
the
cleanup-service-endpoint
branch
from
4832e8c to
4e88d72
Compare
c3y1huang
approved these changes
Aug 23, 2024
|
@mergify backport v1.7.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9272
What this PR does / why we need it:
We meet a corner case that the service/endpoint would not be cleanup. That will cause the service keep the ClusterIP
None. With this config, the endpoint of sharemanager would not be correct, so the CSI driver cannot perform the mountpoint well.We would like to have a checking mechanism to know if the service/endpoint did not cleanup. Then we will cleanup the service/endpoint to ensure the correct endpoint.
Special notes for your reviewer:
Additional documentation or context