Skip to content

feat(backingimage): backing image clone and encryption support #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat(backingimage): backing image clone and encryption support #2876

merged 1 commit into from
Jul 3, 2024

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin commented Jun 14, 2024 •
edited
Loading

@ChanYiLin ChanYiLin requested review from derekbit and shuo-wu June 14, 2024 09:02
@ChanYiLin ChanYiLin self-assigned this Jun 14, 2024
@ChanYiLin ChanYiLin marked this pull request as draft June 14, 2024 09:02
@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch from ffedcde to 3d522ce Compare June 14, 2024 09:06
@ChanYiLin ChanYiLin mentioned this pull request Jun 14, 2024
Closed
@mergify Mergify
Copy link

mergify bot commented Jun 15, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin marked this pull request as ready for review June 20, 2024 08:54
@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch 2 times, most recently from 3df0071 to 57dd869 Compare June 20, 2024 09:42
@mergify Mergify
Copy link

mergify bot commented Jun 26, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin
Copy link
Contributor Author

Feedback from UI, thanks to @a110605

  • webhook should check if the secret exists or not
  • create backing image / restore backing image should allow user to specify the secret if the backing image is already encrypted
  • clone an encrypted backing image should inherit the secret

@a110605 a110605 mentioned this pull request Jun 26, 2024
Merged
derekbit
derekbit reviewed Jun 26, 2024
View reviewed changes
@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch from 57dd869 to bd4ec9c Compare June 26, 2024 09:15
@ChanYiLin
Copy link
Contributor Author

Feedback from UI, thanks to @a110605

  • webhook should check if the secret exists or not
  • create backing image / restore backing image should allow user to specify the secret if the backing image is already encrypted
  • clone an encrypted backing image should inherit the secret

Have addressed the changes

@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch 7 times, most recently from 92adad7 to 751e51a Compare June 28, 2024 08:44
@ChanYiLin ChanYiLin requested a review from derekbit June 28, 2024 08:53
@mergify Mergify
Copy link

mergify bot commented Jun 29, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch 2 times, most recently from 569c801 to 50822b2 Compare July 2, 2024 07:45
@ChanYiLin
Copy link
Contributor Author

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

fixed.

@mergify Mergify
Copy link

mergify bot commented Jul 2, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch 2 times, most recently from ecd0559 to e66b94e Compare July 2, 2024 09:39
@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch from e66b94e to f35d2da Compare July 3, 2024 02:00
@mergify Mergify
Copy link

mergify bot commented Jul 3, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch from f35d2da to c02abe2 Compare July 3, 2024 02:55
@ChanYiLin
Copy link
Contributor Author

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

fixed.

@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch from c02abe2 to 98562f5 Compare July 3, 2024 03:08
derekbit
derekbit previously approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChanYiLin
feat(backingimage): backing image clone and encryption support
1067454 
ref: longhorn/longhorn 7051

Signed-off-by: Jack Lin <[email protected]>
@ChanYiLin ChanYiLin force-pushed the LH7051_backingimage_encryption_support branch from 98562f5 to 1067454 Compare July 3, 2024 03:09
@derekbit derekbit merged commit 369be1a into longhorn:master Jul 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

@shuo-wu shuo-wu Awaiting requested review from shuo-wu

Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChanYiLin @derekbit