Skip to content

Enhance env_id configuration to accept numeric values #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bardabun
Copy link
Contributor

Changes

  • Adjusted validations to ensure env_id is processed correctly when provided as a numeric value.

@bardabun bardabun requested a review from ralongit April 14, 2024 15:01
Copy link
Contributor

@ralongit ralongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@ralongit ralongit changed the base branch from master to release/logzio-monitoring-v5.3.0 April 16, 2024 10:24
@ralongit ralongit merged commit aa0c730 into release/logzio-monitoring-v5.3.0 Apr 16, 2024
2 of 3 checks passed
ralongit added a commit that referenced this pull request Apr 17, 2024
* Logzio logs collector 1.0.1 (#458)

* Update multiline.md

* update multiline parsing and error detection

* change log

* Release logzio-telemetry v4.2.0 (#459)

- Upgraded `opentelemetry-collector-contrib` image to `v0.97.0`
- Added Kubernetes objects receiver
- Removed servicegraph connector from span metrics configuration
- Allow `env_id` & `p8s_logzio_name` non string values

* Bugfix/logs collector default log type (#460)

* Update Chart.yaml

* Change default log type

* Add support for numeric values in env_id (#457)

Co-authored-by: Ral G <[email protected]>

* Logzio monitoring 5.3.0 upgrade (#461)

* Create NOTES.txt

* Add `logzio-logs-collector` + `fluentd.enabled` values

* Update Chart.yaml

* edit `maintainers`

* change log

* Update NOTES.txt

* Update README.md

* Update README.md

* Update NOTES.txt

* 5.2.5

* update docs and change log

* Upgrade sub charts

---------

Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Nico <[email protected]>
Co-authored-by: Yotam loewenbach <[email protected]>

* Update README.md

* Fix readme install command

---------

Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Bar <[email protected]>
Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Nico <[email protected]>
ralongit added a commit that referenced this pull request Apr 17, 2024
* Logzio logs collector 1.0.1 (#458)

* Update multiline.md

* update multiline parsing and error detection

* change log

* Release logzio-telemetry v4.2.0 (#459)

- Upgraded `opentelemetry-collector-contrib` image to `v0.97.0`
- Added Kubernetes objects receiver
- Removed servicegraph connector from span metrics configuration
- Allow `env_id` & `p8s_logzio_name` non string values

* Bugfix/logs collector default log type (#460)

* Update Chart.yaml

* Change default log type

* Add support for numeric values in env_id (#457)

Co-authored-by: Ral G <[email protected]>

* Logzio monitoring 5.3.0 upgrade (#461)

* Create NOTES.txt

* Add `logzio-logs-collector` + `fluentd.enabled` values

* Update Chart.yaml

* edit `maintainers`

* change log

* Update NOTES.txt

* Update README.md

* Update README.md

* Update NOTES.txt

* 5.2.5

* update docs and change log

* Upgrade sub charts

---------

Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Nico <[email protected]>
Co-authored-by: Yotam loewenbach <[email protected]>

* Update README.md

* Fix readme install command

* Revert monitoring chart versions temporarily

---------

Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Bar <[email protected]>
Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Nico <[email protected]>
ralongit added a commit that referenced this pull request Apr 17, 2024
* Logzio logs collector 1.0.1 (#458)

* Update multiline.md

* update multiline parsing and error detection

* change log

* Release logzio-telemetry v4.2.0 (#459)

- Upgraded `opentelemetry-collector-contrib` image to `v0.97.0`
- Added Kubernetes objects receiver
- Removed servicegraph connector from span metrics configuration
- Allow `env_id` & `p8s_logzio_name` non string values

* Bugfix/logs collector default log type (#460)

* Update Chart.yaml

* Change default log type

* Add support for numeric values in env_id (#457)

Co-authored-by: Ral G <[email protected]>

* Logzio monitoring 5.3.0 upgrade (#461)

* Create NOTES.txt

* Add `logzio-logs-collector` + `fluentd.enabled` values

* Update Chart.yaml

* edit `maintainers`

* change log

* Update NOTES.txt

* Update README.md

* Update README.md

* Update NOTES.txt

* 5.2.5

* update docs and change log

* Upgrade sub charts

---------

Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Nico <[email protected]>
Co-authored-by: Yotam loewenbach <[email protected]>

* Update README.md

* Fix readme install command

* Revert monitoring chart versions temporarily

* Upgrade logzio-monitoring chart.yaml versions to v5.3.0

---------

Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Bar <[email protected]>
Co-authored-by: Yotam loewenbach <[email protected]>
Co-authored-by: Nico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants