Skip to content

Migrate from javax package to jakarta #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>io.logz</groupId>
<artifactId>guice-jersey</artifactId>
<version>1.1.0</version>
<version>2.0.0</version>

<packaging>jar</packaging>
<name>guice-jersey</name>
Expand Down Expand Up @@ -129,12 +129,12 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<hk2-bridge.version>2.6.1</hk2-bridge.version>
<jersey.version>2.36</jersey.version>
<jetty.version>10.0.11</jetty.version>
<guice.version>5.1.0</guice.version>
<hk2-bridge.version>3.0.4</hk2-bridge.version>
<jersey.version>3.0.10</jersey.version>
<jetty.version>11.0.15</jetty.version>
<guice.version>7.0.0</guice.version>
<slf4j.version>1.7.36</slf4j.version>
<jackson.version>2.13.3</jackson.version>
<jackson.version>2.15.0</jackson.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -215,8 +215,8 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
<artifactId>jackson-jaxrs-json-provider</artifactId>
<groupId>com.fasterxml.jackson.jakarta.rs</groupId>
<artifactId>jackson-jakarta-rs-json-provider</artifactId>
<version>${jackson.version}</version>
<scope>test</scope>
</dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import org.jvnet.hk2.guice.bridge.api.GuiceBridge;
import org.jvnet.hk2.guice.bridge.api.GuiceIntoHK2Bridge;

import javax.inject.Inject;
import javax.servlet.ServletContext;
import jakarta.inject.Inject;
import jakarta.servlet.ServletContext;

public class GuiceJerseyResourceConfig extends ResourceConfig {

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/io/logz/guice/jersey/JerseyServer.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.servlet.DispatcherType;
import jakarta.servlet.DispatcherType;
import java.util.Collections;
import java.util.EnumSet;
import java.util.List;
Expand Down Expand Up @@ -75,7 +75,7 @@ private void configureServer() {
webAppContext.addFilter(GuiceFilter.class, "/*", EnumSet.allOf(DispatcherType.class));

ServletHolder holder = new ServletHolder(ServletContainer.class);
holder.setInitParameter("javax.ws.rs.Application", GuiceJerseyResourceConfig.class.getName());
holder.setInitParameter("jakarta.ws.rs.Application", GuiceJerseyResourceConfig.class.getName());

webAppContext.addServlet(holder, "/*");
webAppContext.setResourceBase("/");
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.logz.guice.jersey.configuration;

import org.eclipse.jetty.server.HttpConfiguration;
import org.glassfish.jersey.server.ResourceConfig;

import java.util.ArrayList;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

/**
* Implement to provide additional configuration for the underlying {@link org.eclipse.jetty.webapp.WebAppContext},
* like adding a {@link javax.servlet.Filter} or {@link java.util.EventListener}, etc.
* like adding a {@link jakarta.servlet.Filter} or {@link java.util.EventListener}, etc.
*/
@FunctionalInterface
public interface JerseyWebApplicationConfigurator {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import io.logz.guice.jersey.supplier.JerseyServerSupplier;
import org.junit.Test;

import javax.ws.rs.core.Response;
import jakarta.ws.rs.core.Response;

import static org.junit.Assert.assertEquals;

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/io/logz/guice/jersey/JacksonFeatureTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
import org.glassfish.jersey.server.ResourceConfig;
import org.junit.Test;

import javax.ws.rs.client.Entity;
import javax.ws.rs.core.MediaType;
import jakarta.ws.rs.client.Entity;
import jakarta.ws.rs.core.MediaType;
import java.util.Date;

import static org.junit.Assert.assertEquals;
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/io/logz/guice/jersey/JerseyServerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
import org.glassfish.jersey.server.ResourceConfig;
import org.junit.Test;

import javax.ws.rs.ProcessingException;
import javax.ws.rs.client.ClientBuilder;
import javax.ws.rs.client.WebTarget;
import javax.ws.rs.core.Response;
import jakarta.ws.rs.ProcessingException;
import jakarta.ws.rs.client.ClientBuilder;
import jakarta.ws.rs.client.WebTarget;
import jakarta.ws.rs.core.Response;
import java.net.Socket;
import java.util.concurrent.TimeUnit;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import org.eclipse.jetty.servlet.FilterHolder;
import org.junit.Test;

import javax.servlet.DispatcherType;
import javax.ws.rs.core.Response;
import jakarta.servlet.DispatcherType;
import jakarta.ws.rs.core.Response;
import java.util.EnumSet;
import java.util.HashMap;
import java.util.Map;
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/io/logz/guice/jersey/ServerSentEventsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import org.glassfish.jersey.server.ResourceConfig;
import org.junit.Test;

import javax.ws.rs.client.Entity;
import javax.ws.rs.sse.SseEventSource;
import jakarta.ws.rs.client.Entity;
import jakarta.ws.rs.sse.SseEventSource;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicReference;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package io.logz.guice.jersey.filters;

import javax.servlet.Filter;
import javax.servlet.FilterChain;
import javax.servlet.FilterConfig;
import javax.servlet.ServletException;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
import javax.servlet.http.HttpServletResponse;
import jakarta.servlet.Filter;
import jakarta.servlet.FilterChain;
import jakarta.servlet.FilterConfig;
import jakarta.servlet.ServletException;
import jakarta.servlet.ServletRequest;
import jakarta.servlet.ServletResponse;
import jakarta.servlet.http.HttpServletResponse;
import java.io.IOException;

public class AddHeaderJettyFilter implements Filter {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package io.logz.guice.jersey.filters;

import javax.inject.Singleton;
import jakarta.inject.Singleton;

@Singleton
public class FilterHeaderService {
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/io/logz/guice/jersey/filters/TestFilter.java
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package io.logz.guice.jersey.filters;

import javax.inject.Inject;
import javax.ws.rs.container.ContainerRequestContext;
import javax.ws.rs.container.ContainerResponseContext;
import javax.ws.rs.container.ContainerResponseFilter;
import jakarta.inject.Inject;
import jakarta.ws.rs.container.ContainerRequestContext;
import jakarta.ws.rs.container.ContainerResponseContext;
import jakarta.ws.rs.container.ContainerResponseFilter;
import java.io.IOException;

import static java.util.Objects.requireNonNull;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

import org.glassfish.jersey.server.ManagedAsync;

import javax.ws.rs.GET;
import javax.ws.rs.Path;
import javax.ws.rs.container.AsyncResponse;
import javax.ws.rs.container.Suspended;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.container.AsyncResponse;
import jakarta.ws.rs.container.Suspended;

@Path(AsyncResource.PATH)
public class AsyncResource {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.logz.guice.jersey.resources;

import javax.ws.rs.GET;
import javax.ws.rs.Path;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;

@Path(PingResource.PATH)
public class PingResource {
Expand Down
14 changes: 7 additions & 7 deletions src/test/java/io/logz/guice/jersey/resources/PojoResource.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

import io.logz.guice.jersey.beans.TestBean;

import javax.ws.rs.Consumes;
import javax.ws.rs.GET;
import javax.ws.rs.POST;
import javax.ws.rs.Path;
import javax.ws.rs.Produces;
import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
import jakarta.ws.rs.Consumes;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.POST;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.Produces;
import jakarta.ws.rs.core.MediaType;
import jakarta.ws.rs.core.Response;
import java.util.Date;
import java.util.Random;

Expand Down
18 changes: 9 additions & 9 deletions src/test/java/io/logz/guice/jersey/resources/SseResource.java
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package io.logz.guice.jersey.resources;

import javax.ws.rs.DELETE;
import javax.ws.rs.GET;
import javax.ws.rs.POST;
import javax.ws.rs.Path;
import javax.ws.rs.Produces;
import javax.ws.rs.core.Context;
import javax.ws.rs.core.MediaType;
import javax.ws.rs.sse.Sse;
import javax.ws.rs.sse.SseEventSink;
import jakarta.ws.rs.DELETE;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.POST;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.Produces;
import jakarta.ws.rs.core.Context;
import jakarta.ws.rs.core.MediaType;
import jakarta.ws.rs.sse.Sse;
import jakarta.ws.rs.sse.SseEventSink;
import java.io.IOException;

import static java.util.Objects.requireNonNull;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.logz.guice.jersey.resources;

import javax.ws.rs.GET;
import javax.ws.rs.Path;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;

@Path(TestResource.PATH)
public class TestResource {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.logz.guice.jersey.resources.recursive;

import javax.ws.rs.GET;
import javax.ws.rs.Path;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;

@Path(FooResource.PATH)
public class FooResource {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.ws.rs.client.Client;
import javax.ws.rs.client.ClientBuilder;
import javax.ws.rs.client.WebTarget;
import jakarta.ws.rs.client.Client;
import jakarta.ws.rs.client.ClientBuilder;
import jakarta.ws.rs.client.WebTarget;
import java.util.ArrayList;
import java.util.List;

Expand Down