perf: reuse inner packforward payload unpacker #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
force-pushed
the
reuse-packforward-payload-unpacker
branch
from
f78fb3a to
4e46d3e
Compare
mashhurs
reviewed
Mar 20, 2024
Co-authored-by: Mashhur <[email protected]>
andsel
reviewed
Mar 21, 2024
| @@ -116,7 +117,7 @@ def decode_event(data, &block) | |||
| raise(LogStash::Error, "PackedForward with compression is not supported") | |||
| end | |||
|
|
|||
| entries_decoder = @factory.unpacker | |||
| entries_decoder = (@packforward_decoder ||= @factory.unpacker).tap(&:reset) | |||
There was a problem hiding this comment.
As I understand decode, when used by a input like TCP (which is multithreaded), is used by multiple threads, so I have feeling that @packforward_decoder.reset could be called and used by multiple threads.
WDYT?
There was a problem hiding this comment.
TCP clones the codec (as do other inputs), and gives a fresh codec to each connection, so this should never be shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A codec instance needs at-most-one packforward payload unpacker, as it is never decoding input concurrently, so long as the unpacker is reset before use.