Time Series

[jamesmcclain]

• Unit Tests

Fixes #2287

[jamesmcclain]

@CloudNiner and @fungjj92 asked to be tagged on this pull request. See also locationtech-labs/geopyspark#377.

[lossyrob]

Having this be Geometries makes the code less typesafe. If we pass in other geometries, we get a match error that is potentially not very descriptive. We should change this to only accept a Polygon or MultiPolygon, both versions (the user can create the MultiPolygon themselves if needed).

[jamesmcclain]

Okay, I have modified it.

[lossyrob]

Sorry, I should have been more clear. The overloads that should exist are Polygon and MultiPolygon, not MultiPolygon and Traversable[MultiPolygon].

If a user has a single polygon, which seems like a pretty regular case, then they can call the method with just the polygon.

If a user has a multipolygon, same thing.

If the user has a sequence of polygons or sequence of multipolygons, then they can wrap/union them into a multipolygon before calling this method.

[jamesmcclain]

Okay, there are only methods for Polygon and MultiPolygon.

[echeipesh]

My only question here is about the interface, should this be returning Map or RDD, .collect.toMap could be the client calls and returning an RDD[ZonedDateTime, V] would be the first case of its usage. Hard to say right now, this does what it needs to do at the moment.

I think the method extensions need to be @Experimental so we have the freedom to change them as we use them more but otherwise it looks good.