💄 style: Allow Gemini as custom provider #8190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sxjeru is attempting to deploy a commit to the LobeHub Community Team on Vercel. A member of the Team first needs to authorize it. |
Reviewer's GuideImplement name fallback to ID for new AI providers and add Gemini as an SDK type option. Sequence Diagram for AI Provider Creation with Name Fallback LogicsequenceDiagram
actor User
participant CreateNewProviderForm as Form UI
participant CreateNewProviderComponent as Component Logic
participant createNewAiProviderFunc as createNewAiProvider()
User->>CreateNewProviderForm: Fills provider details (ID, optional Name, SDK Type, etc.)
User->>CreateNewProviderForm: Submits form
CreateNewProviderForm->>CreateNewProviderComponent: onSubmit(values)
CreateNewProviderComponent->>CreateNewProviderComponent: finalName = values.name ? values.name : values.id
CreateNewProviderComponent->>createNewAiProviderFunc: Call with {..., name: finalName, ...}
createNewAiProviderFunc-->>CreateNewProviderComponent: Promise (e.g., success)
alt Creation Successful
CreateNewProviderComponent->>User: Display success message
CreateNewProviderComponent->>User: Redirect to provider page
else Creation Failed
CreateNewProviderComponent->>User: Display error message
end
Class Diagram: Updated Form Configuration and SDKTypeclassDiagram
class NameFormFieldConfig {
+label: string
+minWidth: number
+name: string
%% Former attribute 'rules: [{ required: true }]' was removed, making the field optional in UI validation %%
}
class SdkTypeEnum {
<<enumeration>>
OPENAI
ANTHROPIC
OLLAMA
GOOGLE %% New value 'google' added for Gemini %%
}
class ProviderCreationPayload {
+id: string
+name: string %% Value is 'values.name' or 'values.id' if 'values.name' is empty %%
+sdkType: SdkTypeEnum
%% Other provider-specific fields %%
}
ProviderCreationPayload *-- SdkTypeEnum : uses
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
dosubot
bot
added
the
size:S
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
👍 @sxjeru Thank you for raising your pull request and contributing to our Community |
TestGru AssignmentSummary
Tip You can |
sxjeru
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8190 +/- ##
==========================================
- Coverage 95.67% 87.86% -7.81%
==========================================
Files 14 836 +822
Lines 2522 62355 +59833
Branches 445 3937 +3492
==========================================
+ Hits 2413 54791 +52378
- Misses 109 7564 +7455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
不知道能不能这样改，目前无法在启用客户端请求的情况下正常使用。
根据测试，anthropic 类型的自定义提供商也不支持客户端请求，可能是 lobechat 没有做支持，可以暂时考虑隐藏掉客户端请求开关。
另服务商名称不再必需，为空时自动采用服务商 id 。
📝 补充信息 | Additional Information
Summary by Sourcery
Enable using ID as a fallback name for new AI providers, remove mandatory name validation, and introduce Gemini to the SDK type dropdown.
New Features:
Enhancements: