Skip to content

[test] Now git diff in basic regression tests should capture the changes on golden outputs #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 21, 2022

Conversation

tangxifan
Copy link
Collaborator

@tangxifan tangxifan commented Sep 20, 2022

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

This PR improves in the following aspects:

  • Fixed the bug in the io_center test cases. No more I/Os on the corners of center fabric.
  • Fixed the bug in the git diff which failed to capture golden output changes

Which part of the code base require a change

  • VPR
  • Tileable routing architecture generator
  • OpenFPGA libraries
  • FPGA-Verilog
  • FPGA-Bitstream
  • FPGA-SDC
  • FPGA-SPICE
  • Flow scripts
  • Architecture library
  • Cell library
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@github-actions github-actions bot added the tests label Sep 20, 2022
@tangxifan
Copy link
Collaborator Author

Waive the error in basic regression tests, as the golden netlists are not sync-up when building the docker image.

run: |
bash .github/workflows/install_dependencies_run.sh
${PYTHON_EXEC} -m pip install -r requirements.txt
rsync -am --exclude='openfpga_flow/**' /opt/openfpga/. .
unset OPENFPGA_PATH
source openfpga.sh && source openfpga_flow/regression_test_scripts/${{matrix.config.name}}.sh --debug --show_thread_logs

@tangxifan tangxifan merged commit 1354a4b into master Sep 21, 2022
@tangxifan tangxifan deleted the reg_hotfix branch September 21, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant