[FIX] Replace stored atomic volumes with computed ones #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lmmentel merged 2 commits into master from fix/atomic_volume

Feb 15, 2025

Owner

lmmentel commented Feb 15, 2025 •

edited

Loading

Fixes #226

Proposed Changes

remove the stored atomic_volume from the elements table since it's missing a reference and might have inconsistent units
added atomic_volume hybrid property that computes the property based on atomic weight and density


          replaced stored atomic volume with computed

cb08395

lmmentel added data bugfix labels


          switch vis property to density instead of atomic_volume

021f4d6

lmmentel merged commit 44ad1b6 into master

20 checks passed

lmmentel deleted the fix/atomic_volume branch

February 15, 2025 22:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels