-
Notifications
You must be signed in to change notification settings - Fork 286
add chi2_out and nsigma options to conf_interval2d #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
- Coverage 93.75% 93.72% -0.03%
==========================================
Files 10 10
Lines 3520 3522 +2
==========================================
+ Hits 3300 3301 +1
- Misses 220 221 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @newville - this is a nice enhancement with a good example on how to use it and I'd say almost ready to merge! I've left a few tiny comments for your consideration.
I am going through the other PR - sorry it takes me so long.... I might try to clean-up the commit history there a bit to group related commits together so it's easier to follow. Of course, if you want that PR already without any clean-up -- I know. you don't mind a bit of mess too much ;) -- that's fine with me as well.
@reneeotten thanks very much, I made all suggested changes. And, yeah, I know that #844 is slightly enormous and started to grow several not-exactly-related changes. I'm definitely OK with merging this and #853 before #844. |
Description
This adds
chi2_out
andnsigma
parameters toconf_interval2d
, and adds documentation and an example of using it to make contour maps from a matrix of chi-square values.This works to clarify some of the discussion at #848
Type of Changes
Tested on
Python: 3.9.15 (main, Nov 24 2022, 08:29:02)
[Clang 14.0.6 ]
lmfit: 1.1.0.post9+gd2ba8e9.d20230312, scipy: 1.9.3, numpy: 1.23.5, asteval: 0.9.29, uncertainties: 3.1.7
Verification
Have you