Remove pre-compiled binaries #229
Merged
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least was here since the project was imported - a23d327. |
DavidSpickett
approved these changes
Apr 4, 2025
For some reason, we have three pre-compiled binaries checked in for the gs, agrep and football benchmarks. These are not actually used (we'll build our own, as usual). Presumably they were committed by accident. We also ship one more pre-compiled makeproto binary for the p2c benchmark. This is not necessary either, as we already ship the `.proto` files it generates.
Nope, these were just flagged by some compliance tooling. But we remove some subdirectories for licensing reasons, so there are actually more... I did a more thorough check with Worth noting that makeproto is different from the rest in that we don't seem to ship the source for it, but we do ship the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, we have three pre-compiled binaries checked in for the gs, agrep and football benchmarks. These are not actually used (we'll build our own, as usual). Presumably they were committed by accident.
We also ship one more pre-compiled makeproto binary for the p2c benchmark. This is not necessary either, as we already ship the
.protofiles it generates.