[sanitizer] Fix running sanitizer_set_report_path_test on Android #99469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanitizer_set_report_path_test outputs the following on an Android
builder [1]:
ERROR: Can't create directory: /data/local/tmp/Output/var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/compiler_rt_build_android_arm/test/sanitizer_common/asan-arm-Android/Posix/Output/sanitizer_set_report_path_test.cpp.tmp
Path /data/local/tmp/Output/var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/compiler_rt_build_android_arm/test/sanitizer_common/asan-arm-Android/Posix/Output/sanitizer_set_report_path_test.cpp.tmp.report_path/report.24954
The order of messages is reversed. The "Path" message is printed with
printf(), and the "ERROR:" message is printed with
write(STDERR_FILENO). However, there is an fflush() in between, which
is supposed to prevent reordering.
Work around the issue by using write(STDERR_FILENO) to write the
"Path" message.
[1] https://lab.llvm.org/buildbot/#/builders/186/builds/703/steps/26/logs/stdio
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Ilya Leoshkevich (iii-i) Changessanitizer_set_report_path_test outputs the following on an Android builder [1]: The order of messages is reversed. The "Path" message is printed with printf(), and the "ERROR:" message is printed with write(STDERR_FILENO). However, there is an fflush() in between, which is supposed to prevent reordering. Work around the issue by using write(STDERR_FILENO) to write the "Path" message. [1] https://lab.llvm.org/buildbot/#/builders/186/builds/703/steps/26/logs/stdio Full diff: https://github.com/llvm/llvm-project/pull/99469.diff 1 Files Affected:
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
index 286eafc315baf..1b5b6c099a383 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
@@ -6,6 +6,7 @@
#include <sanitizer/common_interface_defs.h>
#include <stdio.h>
#include <string.h>
+#include <unistd.h>
volatile int *null = 0;
@@ -14,13 +15,14 @@ int main(int argc, char **argv) {
sprintf(buff, "%s.report_path/report", argv[0]);
__sanitizer_set_report_path(buff);
assert(strncmp(buff, __sanitizer_get_report_path(), strlen(buff)) == 0);
- printf("Path %s\n", __sanitizer_get_report_path());
- fflush(stdout);
+ sprintf(buff, "Path %s\n", __sanitizer_get_report_path());
+ write(STDERR_FILENO, buff, strlen(buff));
// Try setting again with an invalid/inaccessible directory.
sprintf(buff, "%s/report", argv[0]);
__sanitizer_set_report_path(buff);
- printf("Path %s\n", __sanitizer_get_report_path());
+ sprintf(buff, "Path %s\n", __sanitizer_get_report_path());
+ write(STDERR_FILENO, buff, strlen(buff));
}
// CHECK: Path {{.*}}Posix/Output/sanitizer_set_report_path_test.cpp.tmp.report_path/report.
|
vitalybuka
reviewed
Jul 18, 2024
compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_test.cpp
Outdated
Show resolved
Hide resolved
vitalybuka
approved these changes
Jul 18, 2024
|
The build is green again (https://lab.llvm.org/buildbot/#/builders/186/builds/733). Thanks! |
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
…9469) sanitizer_set_report_path_test outputs the following on an Android builder [1]: ERROR: Can't create directory: /data/local/tmp/Output/var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/compiler_rt_build_android_arm/test/sanitizer_common/asan-arm-Android/Posix/Output/sanitizer_set_report_path_test.cpp.tmp Path /data/local/tmp/Output/var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/compiler_rt_build_android_arm/test/sanitizer_common/asan-arm-Android/Posix/Output/sanitizer_set_report_path_test.cpp.tmp.report_path/report.24954 The order of messages is reversed. The test can use strcmp+assert instead of CHECK for `__sanitizer_get_report_path` output. [1] https://lab.llvm.org/buildbot/#/builders/186/builds/703/steps/26/logs/stdio --------- Co-authored-by: Vitaly Buka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanitizer_set_report_path_test outputs the following on an Android builder [1]:
The order of messages is reversed. The "Path" message is printed with printf(), and the "ERROR:" message is printed with write(STDERR_FILENO). However, there is an fflush() in between, which is supposed to prevent reordering.
Work around the issue by using write(STDERR_FILENO) to write the "Path" message.
[1] https://lab.llvm.org/buildbot/#/builders/186/builds/703/steps/26/logs/stdio