Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[libc++] Implement C++20 atomic_ref #76647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc++] Implement C++20 atomic_ref #76647
Changes from 77 commits
f173470
3d8d9db
f05a599
6e01477
1575d41
2767cf0
d79c427
722217b
1a0463f
5e5a5cd
d5525ad
a974df0
4172781
02220ba
8cc91fb
28e4f55
0391ec0
82fcdad
4fec87c
f763a3a
259afbf
f0cbfec
46ab572
f9edc9f
2438001
255559f
8ebfe2d
a745599
07ecf37
ba4ec71
b476c80
21bf066
6df2fa8
05dad2c
991ccb6
bd870b0
c10501c
6d310d8
7d8a1c8
89424db
956f4b3
6d5c9de
8ad10b6
ee7cb80
6ef3362
ed91c8c
dee15ac
79876f0
5c0c3c9
a795159
54220e5
c185cfd
55ee31a
bc5a5df
4616b46
fe1027c
e2b1529
d935cb4
dabe768
3ec8d68
54b6230
8a29a08
e2e4c6c
becd644
4d7c3a8
e4da1e0
e09ac7a
cee65ac
7e68d6c
3cc65a5
f64b44f
64941f1
8101aff
ef5fb5a
e656ca2
9c20e50
919e8c9
cce18df
6815d2b
049b3d7
505ddb5
a593fa0
0a03362
41b1eff
4279d70
12ecd1d
d7ff8c9
7492f36
3d6645b
75d3a66
9b81d05
6ae8d85
8fef446
856d2dd
e39d261
ee8a50e
47d3cde
9c85f18
233f568
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not an issue. we do have builtins for RMW operations for floating points in clang. but i guess gcc does not have it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I don't remember. IIRC I did this it because I had seen failures in some builds in the CI. I am not sure how we would guard against versions of the builtins that support atomic operations on fp.
I can undo and check more in details what happens if you like. Let me know what you think.