[workflows] Use -g instead of -g1 for the abi tests #133968
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should improve the debuginfo and hopefully make the abi tests more accurate. I think -g1 was originally used to save disk space, but the GitHub runners have more disk space now, so it isn't necessary.
|
If we want to save space, can't we use -gz? |
nikic
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
LGTM, though I wonder whether it might make sense to just switch to the RelWithDebugInfo configuration now, instead of manually specifying CFLAGS? That would use -O2 instead of -Og, but I don't think that should really matter for the purposes of ABI comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the debuginfo and hopefully make the abi tests more accurate. I think -g1 was originally used to save disk space, but the GitHub runners have more disk space now, so it isn't necessary.