Skip to content

[tsan] Fix typo in type #115769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[tsan] Fix typo in type #115769

merged 1 commit into from
Nov 11, 2024

Conversation

vitalybuka
Copy link
Collaborator

@vitalybuka vitalybuka commented Nov 11, 2024

Introduced with #114931
Fixes golang/go#70283

Created using spr 1.3.4
@llvmbot
Copy link
Member

llvmbot commented Nov 11, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Vitaly Buka (vitalybuka)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/115769.diff

1 Files Affected:

  • (modified) compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp (+1-1)
diff --git a/compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp b/compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp
index f95b95735e0e31..527e5a9b4a8d8a 100644
--- a/compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp
@@ -987,7 +987,7 @@ SANITIZER_INTERFACE_ATTRIBUTE
 void __tsan_go_atomic64_compare_exchange(ThreadState *thr, uptr cpc, uptr pc,
                                          u8 *a) {
   a64 cmp = *(a64 *)(a + 8);
-  a32 cur = AtomicGoRet<OpCAS>(thr, cpc, pc, mo_acq_rel, mo_acquire, *(a64 **)a,
+  a64 cur = AtomicGoRet<OpCAS>(thr, cpc, pc, mo_acq_rel, mo_acquire, *(a64 **)a,
                                cmp, *(a64 *)(a + 16));
   *(bool *)(a + 24) = (cur == cmp);
 }

@vitalybuka vitalybuka changed the title [tsan] Fix typo [tsan] Fix typo in type Nov 11, 2024
@vitalybuka vitalybuka added the skip-precommit-approval PR for CI feedback, not intended for review label Nov 11, 2024
@vitalybuka vitalybuka merged commit 9254b81 into main Nov 11, 2024
10 of 11 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/tsan-fix-typo branch November 11, 2024 21:16
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler-rt:sanitizer compiler-rt:tsan Thread sanitizer compiler-rt skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime/race: llvm-unstable changes break Go tests with -race: panic: release of handle with refcount 0
2 participants