[NFC][TableGen] Refactor preprocessor directive handling #102967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
approved these changes
Aug 12, 2024
llvm/lib/TableGen/TGLexer.cpp
Outdated
| }; | ||
| } // end anonymous namespace | ||
|
|
||
| static constexpr PreprocessorDir PreprocessorDirs[] = { |
There was a problem hiding this comment.
Just constexpr. This has internal linkage even without static
How about: Refactor preprocessor directive handling in TableGen ? |
- Make `PreprocessorDirs` array constexpr, move its definition outside the anonymous namespace, and make it static. - Change `Word` field to a StringRef. - Simplify `prepIsDirective` to use StringRef comparison and early `continue` per LLVM coding standards. - Use C++17 structured bindings to iterate over the array.
jurahul
force-pushed
the
constexpr_PreprocessorDirs
branch
from
55536b6 to
00f731f
Compare
jurahul
changed the title
s-barannikov
approved these changes
Aug 13, 2024
|
Thanks @s-barannikov. Can one of you please merge the PR? |
|
Thanks! |
jurahul
added a commit
to jurahul/llvm-project
that referenced
this pull request
Aug 13, 2024
- Fixes an issue in llvm#102967, which inddvertently changed the type of `NextChar` from int to char, causing ppc64le build failures.
s-barannikov
pushed a commit
that referenced
this pull request
Aug 13, 2024
Fixes an issue in #102967, which inddvertently changed the type of `NextChar` from int to char, causing ppc64le build failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreprocessorDirsarray constexpr, move its definition outside the anonymous namespace, and make it static.Wordfield to a StringRef.prepIsDirectiveto use StringRef comparison and earlycontinueper LLVM coding standards.