-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[libc] Enable 'sscanf' on the GPU #100211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-libc Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/100211.diff 2 Files Affected:
diff --git a/libc/config/gpu/entrypoints.txt b/libc/config/gpu/entrypoints.txt
index fa878d8999227..f7e89bdcd95cc 100644
--- a/libc/config/gpu/entrypoints.txt
+++ b/libc/config/gpu/entrypoints.txt
@@ -186,6 +186,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.stdio.sprintf
libc.src.stdio.vsnprintf
libc.src.stdio.vsprintf
+ libc.src.stdio.sscanf
libc.src.stdio.feof
libc.src.stdio.ferror
libc.src.stdio.fflush
diff --git a/libc/docs/gpu/support.rst b/libc/docs/gpu/support.rst
index 71dd1b30c5e3a..5ef298a2ba58f 100644
--- a/libc/docs/gpu/support.rst
+++ b/libc/docs/gpu/support.rst
@@ -234,10 +234,11 @@ printf |check| |check|
vprintf |check| |check|
fprintf |check| |check|
vfprintf |check| |check|
-sprintf |check| |check|
-snprintf |check| |check|
-vsprintf |check| |check|
-vsnprintf |check| |check|
+sprintf |check|
+snprintf |check|
+vsprintf |check|
+vsnprintf |check|
+sscanf |check|
putchar |check| |check|
fclose |check| |check|
fopen |check| |check|
|
SchrodingerZhu
approved these changes
Jul 23, 2024
Summary: We can enable the `sscanf` function on the GPU now.
jhuber6
added a commit
that referenced
this pull request
Jul 24, 2024
Summary: This fails tests in some situations, revert until it can be fixed. This reverts commit 445bb35.
jhuber6
added a commit
that referenced
this pull request
Jul 24, 2024
Summary: We can enable the sscanf function on the GPU now. This required adding the configs to the scanf list so that the GPU build didn't do float conversions.
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: We can enable the `sscanf` function on the GPU now. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250594
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: This fails tests in some situations, revert until it can be fixed. This reverts commit 445bb35. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250606
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: We can enable the sscanf function on the GPU now. This required adding the configs to the scanf list so that the GPU build didn't do float conversions. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We can enable the
sscanf
function on the GPU now.