Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyRTG] Refactor targets/configs #8399

Open
wants to merge 1 commit into
base: maerhart-pyrtg-refactor-for-easier-downstream-inclusion
Choose a base branch
from
Open

[PyRTG] Refactor targets/configs #8399

wants to merge 1 commit into from

Conversation

maerhart
Copy link
Member

@maerhart maerhart commented Apr 7, 2025

  • Rename target -> config and entry -> param in PyRTG and make param declaration in a config as well as test argument declaration more convenient
  • rename 'type' staticmethod to 'ty' to avoid confusion with the builtin 'type' which can make debugging annoying in some cases
  • Support 'Value' attributes in classes when passing them across control-flow regions
  • Fix a bug in Elaboration discovered during this refactoring
  • Fix a bug in InlineSequences discovered during this refactoring
  • This also fixes an issue where the test/target arguments weren't sorted properly

@maerhart maerhart added the RTG Involving the `rtg` dialect label Apr 7, 2025
@maerhart maerhart requested review from youngar and darthscsi April 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngar youngar Awaiting requested review from youngar

@darthscsi darthscsi Awaiting requested review from darthscsi

Assignees
No one assigned
Labels
RTG Involving the `rtg` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maerhart