[FIRRTL] Add VersionAttr, put on Circuit, use to parse FIRRTL 6 Annotations #8390
+458
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `VersionAttr` which can be used to store the version of a specific FIRRTL circuit. While this was previously only necessary to be known during parsing, due to planned changed in annotation handling, this information will need to be put on the circuit and preserved through to `LowerAnnotation`. This is the first infrastructural piece necessary to work towards this. Signed-off-by: Schuyler Eldridge <[email protected]>
Add a new attribute to FIRRTL's `CircuitOp` that contains the version that the FIRRTL circuit was parsed as. This is intended to be static information that will change compilation behavior. At present, this is only intended to be used to change how annotations are parsed. However, this is general infrastructure that could be used to make actual breaking compilation changes if we ever needed it. Signed-off-by: Schuyler Eldridge <[email protected]>
Migrate the parser to use VersionAttr instead of FIRVersion. This allows direct comparisons against the version reported by the circuit. Signed-off-by: Schuyler Eldridge <[email protected]>
Add support for the new FIRRTL 6 Annotation format [[1]]. This drops the
circuit portion of the non-legacy annotation format. It also drops
support for the legacy annotation format. Upstream chisel has already
been modified to never emit the legacy annotation format.
For example, annotations that previously looked like:
~Foo|Bar>a
Now must look like:
Bar>a
[1]: chipsalliance/firrtl-spec#290
Signed-off-by: Schuyler Eldridge <[email protected]>
|
After out-of-band discussion, this is not needed. Instead, we can augment the target syntax to optionally elide the circuit name (chipsalliance/firrtl-spec@160bafe). This is already accepted by CIRCT and we don't need to carry the version forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
VersionAttrwhich is made an optional attribute on FIRRTL circuits. This is used to determine which version of the annotation format should be used in theLowerAnnotationspass. This can additionally be used in the future if we ever get into a hard situation where we need to support a legacy behavior in the FIRRTL spec as opposed to just syntax differences or new features.See individual commits for more information.