Skip to content

[MooreToCore] Lower moore.array_create Op #8364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

[MooreToCore] Lower moore.array_create Op #8364

merged 3 commits into from
Apr 2, 2025

Conversation

AnnuCode
Copy link
Contributor

@AnnuCode AnnuCode commented Mar 31, 2025 •
edited
Loading

Fixes #8128

Also, adding this Op conversion passes this test.
@fabianschuiki can you please review this? Any feedback is appreciated.

structure_replication

fabianschuiki
fabianschuiki reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thanks for working on this 🥳! Can you add tests for this to test/Conversion/MooreToCore/basic.mlir as well? The ArrayCreateOp (see MooreOps.td) can produce AnyStaticArrayType results, which is either an ArrayType or an UnpackedArrayType (see MooreTypes.td). It would be good to test both cases.

@AnnuCode AnnuCode requested a review from fabianschuiki April 2, 2025 06:15
@AnnuCode
Copy link
Contributor Author

AnnuCode commented Apr 2, 2025

Really cool, thanks for working on this 🥳! Can you add tests for this to test/Conversion/MooreToCore/basic.mlir as well? The ArrayCreateOp (see MooreOps.td) can produce AnyStaticArrayType results, which is either an ArrayType or an UnpackedArrayType (see MooreTypes.td). It would be good to test both cases.

Thank you, @fabianschuiki! I have added the tests. Can you please check them at your convenience? 🙂

@AnnuCode AnnuCode requested a review from fabianschuiki April 2, 2025 18:28
fabianschuiki
fabianschuiki approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot! 🥳

@fabianschuiki fabianschuiki merged commit fdb946e into llvm:main Apr 2, 2025
5 checks passed
KelvinChung2000 pushed a commit to KelvinChung2000/circt that referenced this pull request Apr 22, 2025
@AnnuCode @KelvinChung2000
[MooreToCore] Lower moore.array_create op (llvm#8364)
bf5e21e 
Fixes llvm#8128.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MooreToCore] Support moore.array_create
2 participants
@AnnuCode @fabianschuiki