Skip to content

[Comb] delete slow canonicalizer #8014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[Comb] delete slow canonicalizer #8014

merged 1 commit into from
Dec 23, 2024

Conversation

youngar
Copy link
Member

@youngar youngar commented Dec 23, 2024

This canonicalizer does not have a functional issue, but it has problematic performance. This change removes it until it can be fixed properly.

This canonicalizer does not have a functional issue, but is causing bad
performance issues.  This change removes it until it can be fixed
properly.
@youngar youngar added the Comb Involving the `comb` dialect label Dec 23, 2024
@youngar youngar requested a review from seldridge December 23, 2024 06:32
@youngar youngar requested a review from darthscsi as a code owner December 23, 2024 06:32
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a tracking issue to re-enable this / re-visit this?

Thanks for tracking this down!

@youngar
Copy link
Member Author

youngar commented Dec 23, 2024

I'll reopen the original ticket: #1624

@youngar youngar merged commit 6f7cba6 into llvm:main Dec 23, 2024
4 checks passed
@youngar youngar deleted the hw-slow-canon branch December 23, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comb Involving the `comb` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants