Skip to content

Is decodeDotInKeys meant to be disabled by default? #500

Closed
@wwaaijer-exh

Description

@wwaaijer-exh

Currently decodeDotInKeys is enabled by default, was this intentional?

We use qs for oAuth1 signature generation, for which it is important to keep keys as they are.
By having decodeDotInKeys automatically enabled by default in 6.12.0, keys are implicitly transformed.

We did not pin the exact version of qs, just the major version.
The moment 6.12.0 was released, new installations started to break.
Following that reasoning, could this be considered a breaking change?

All not that bad though, just something we did not expect to happen.
We're still very satisfied qs users!

As a side note, the examples in the docs show how to enable decodeDotInKeys, implying it is disabled by default.

I'm happy to create a PR to either update the default behavior or change the docs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions