Skip to content

Remove references to Buffer #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjackson opened this issue Aug 26, 2014 · 1 comment · Fixed by #26
Closed

Remove references to Buffer #25

mjackson opened this issue Aug 26, 2014 · 1 comment · Fixed by #26

Comments

@mjackson
Copy link
Contributor

References to the Buffer global variable assume the environment is node.js, but it's a shame to limit the use of this package to node environments when it could easily be used in browsers as well.

Can we modify these checks to make qs more browser-friendly?
@mjackson
Copy link
Contributor Author

AFAICT there are only two references in the code now:

https://github.com/hapijs/qs/blob/b147f4691af78200f3269e84e174869ef000d19f/lib/stringify.js#L13
https://github.com/hapijs/qs/blob/b147f4691af78200f3269e84e174869ef000d19f/lib/utils.js#L31

Both of them use Buffer.isBuffer.

mjackson added a commit to mjackson/qs that referenced this issue Aug 26, 2014
@mjackson
Don't use Buffer global if it's not present
0814d70 
Fixes ljharb#25
@mjackson mjackson mentioned this issue Aug 26, 2014
Merged
@nlf nlf closed this as completed in #26 Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use Buffer global if it's not present mjackson/qs
1 participant
@mjackson