Using sipCallID to map the inviteState and the challenge data between… #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sip auth invites We were using the from number and that ran into issues when there were simultaneous calls from the same from number
…'t be an issue in the tests
dennwc
approved these changes
Jul 20, 2025
| log = log.WithValues("inviteStateFrom", from) | ||
| // Extract SIP Call ID for tracking in-progress invites | ||
| sipCallID := "" | ||
| if h := req.CallID(); h != nil { |
There was a problem hiding this comment.
We should require CallID parameter the same way as we do with From header.
There was a problem hiding this comment.
I actually thought about that. But I was wondering if we should do that at the sipgo level(if it isn't already being done) when parsing the invite. Invite without sipcallID won't be valid at all right ?
There was a problem hiding this comment.
It may be done on the dialog level of sipgo, but for us it looks like it can still be nil. I was thinking that we could add it to the call structure or just get the header earlier and pass it along. We do a similar check for other headers.
| @@ -266,12 +271,19 @@ func (s *Server) processInvite(req *sip.Request, tx sip.ServerTransaction) (retE | |||
| cc.Processing() | |||
| } | |||
|
|
|||
| // Extract SIP Call ID directly from the request | |||
| sipCallID := "" | |||
| if h := req.CallID(); h != nil { | |||
There was a problem hiding this comment.
Same here, we should require CallID to be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… sip auth invites
We were using the from number and that ran into issues when there were simultaneous calls from the same from number