Skip to content

Normalizing From and To Numbers for inbound calls #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nishadmusthafa
Copy link
Contributor

Certain carriers don't follow the E.164 format with numbers in the headers. This would lead to trunk matches failing and calls not working as expected. This takes care of that.

…aders. This would lead to trunk matches failing and calls not working as expected. This takes care of that.
@nishadmusthafa nishadmusthafa requested a review from a team as a code owner June 7, 2025 04:50
Copy link
Contributor

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dangerous change. SIP username may contain arbitrary name, not just numbers. We cannot blindly normalise everything.

@nishadmusthafa nishadmusthafa deleted the normalize-inbound-from-and-to-numbers branch June 10, 2025 21:24
@nishadmusthafa
Copy link
Contributor Author

Moving this further inside for only cloud as it's failing only there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants