feat-consolidated depts file #444
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to replace separate en and fr departments - but not removing them yet
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@lisafast I think the name of the export variables should just be departments, or something like that, not departments_CONSOLIDATED> |
|
@iscryanhyma yes thanks, I'll make sure to change. It turns out a bunch of the organizations don't have abbreviations, so I may have to use their full name - gah! |
new departments file has en and fr combined - makes it easier to manage AND enables use of just the english abbreviations as a unique key. some organizations didn't have abbreviations - i created them in the departments file as unique keys. Some organizations have a null abbr_fr but it doesn't matter because we aren't using the fr abbreviation.
|
I need to test this then will request review. |
new field with combined abbreviation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to replace separate en and fr departments - but not removing them yet
still have to change the context prompt and the context tool?