Skip to content

Add image pull policy and secret handling across components #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

Add image pull policy and secret handling across components #3029

merged 1 commit into from
May 7, 2025

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Apr 29, 2025 •
edited
Loading

Description

This pr adds the possibility to specify image pull secrets for liqo containers

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the chore Miscellaneous tasks that don't modify application logic (e.g., updating dependencies or build tasks) label Apr 29, 2025
@aleoli aleoli force-pushed the aol/image-pull-secret branch 2 times, most recently from 2302b4c to b2d4f3a Compare May 6, 2025 09:03
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 6, 2025
@aleoli
Copy link
Member Author

aleoli commented May 6, 2025

/test

@aleoli aleoli marked this pull request as ready for review May 6, 2025 09:06
@aleoli aleoli requested review from claudiolor, cheina97 and fra98 May 6, 2025 09:06
@aleoli
Copy link
Member Author

aleoli commented May 7, 2025

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the aol/image-pull-secret branch from b2d4f3a to c1d6385 Compare May 7, 2025 14:01
@aleoli
Copy link
Member Author

aleoli commented May 7, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label May 7, 2025
@adamjensenbot adamjensenbot merged commit 7c4ea18 into liqotech:master May 7, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@claudiolor claudiolor Awaiting requested review from claudiolor

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
chore Miscellaneous tasks that don't modify application logic (e.g., updating dependencies or build tasks) size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleoli @adamjensenbot @fra98