Update dashy V3 port #686
Merged
Update dashy V3 port #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Roxedus
approved these changes
Sep 7, 2024
|
This pull request is locked due to inactivity |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the proxy configuration for Dashy to reflect the change in the official image's port from 80 to 8080.
Benefits of this PR and context
This change ensures that the proxy configuration works correctly with the updated Dashy image, which now listens on port 8080 instead of 80. It resolves the issue where users might face connectivity problems due to the incorrect port configuration.
How Has This Been Tested?
Tested the updated proxy configuration in a local development environment to confirm that Dashy is accessible through the proxy on port 8080. Verified that the change does not affect other areas of the code or proxy configurations.
Source / References
Lissy93/dashy#1529
closes #685