Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] : enable nodeipamcontroller within CCM #366

Merged
merged 5 commits into from
Apr 2, 2025
Merged

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Mar 31, 2025

General:

This PR enables CCM to also do node IPAM management. To enable nodeipam-controller, one needs to set --allocate-node-cidrs along with cluster-cidr flag.

spec:
  template:
    spec:
      containers:
        - name: ccm-linode
          args:
            - --allocate-node-cidrs=true
            - --cluster-cidr=10.192.0.0/10
  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions bot added the new-feature for new features in the changelog. label Mar 31, 2025
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 87.32394% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.37%. Comparing base (717a8f3) to head (4a622a2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cloud/linode/nodeipamcontroller.go 91.17% 4 Missing and 2 partials ⚠️
cloud/linode/cloud.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   72.98%   73.37%   +0.38%     
==========================================
  Files          14       15       +1     
  Lines        2599     2670      +71     
==========================================
+ Hits         1897     1959      +62     
- Misses        537      544       +7     
- Partials      165      167       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahulait rahulait merged commit 2209b29 into main Apr 2, 2025
11 checks passed
@rahulait rahulait deleted the add-ipv4-ipam-to-ccm branch April 3, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants